[config] Deprecated config (v1) package #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cast was based on https://github.com/spf13/cast but it only implemented a small amount of methods because in config we no longer use string path to find value in a complex untyped struct, and unmarshal it to struct directly
- the original aim of config package is to support template inside YAML,
kind of like what Ansible is doing, it was invented for Xephon-B.
We first use a non standard template engine (I even forgot its name
now), and then switched to using standard library's `text/template`,
this syntax is a bit awkward when for loop is used, it's ok when using
things like `{{env KEY_NAME}}`
- however, when not writing bechmark config, the template feature is not
that useful, normally I just unmarshal the yaml to struct and that's it
- I am not sure what v2 of config would be, maybe support more format or
enforce the struct/interface of config struct. (It used to have a
validation interface that check the config and its fields manually)
or just allow downloading config file from the wire
- move cast package to util/cast - deprecated config package, move to legacy/config
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 43.28% 40.96% -2.33%
==========================================
Files 53 51 -2
Lines 1915 1738 -177
==========================================
- Hits 829 712 -117
+ Misses 1015 972 -43
+ Partials 71 54 -17
Continue to review full report at Codecov.
|
at15
pushed a commit
to dyweb/go.ice
that referenced
this pull request
Aug 31, 2018
at15
added a commit
to dyweb/go.ice
that referenced
this pull request
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadYAMLAsStructMakefile, it was 0.0.1 all the way ....About the future direction of config package
APP_HTTP_PORT,APP_SERVICE_ENABLEDetc.As for config
yamlas an intermediate to convert interface to struct, after all json is in stdlib and YAML is not