Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on MySQL/MariaDB CREATE PROCEDURE permission #3015

Closed
Deltik opened this issue Jan 28, 2018 · 0 comments
Closed

Remove dependency on MySQL/MariaDB CREATE PROCEDURE permission #3015

Deltik opened this issue Jan 28, 2018 · 0 comments
Labels
type: enhancement An improvement or new feature request
Milestone

Comments

@Deltik
Copy link
Member

Deltik commented Jan 28, 2018

Problem

On Wednesday, 24 January 2018, @CaMer0n asked me:

Good morning! I was wondering if you would mind taking a look at this issue?

In e107_handlers/admin_ui.php is a method: getParentChildQry(). It uses custom MySQL functions to sort by parent/child fields of the table taking into account the 'order' field of the table.

I talked to one of the users about trying to do this is PHP alone to remove this need for mysql-function permissions. Here is his pull-request: #2929

Unfortunately, it didn't work correctly. The best test case is to use the vstore plugin and add some multi-level categories in the admin area.

If you don't have time, I completely understand - please feel no obligation. Just thought you might have the skills to solve this one.

The task is to port the custom MySQL/MariaDB functions getDepth() and getTreeSort() to pure PHP so that e107 will no longer be dependent on the CREATE PROCEDURE permission in MySQL/MariaDB.

Screenshot of Expected Behavior

Screenshot of expected behavior

@CaMer0n CaMer0n added the type: enhancement An improvement or new feature request label Jan 28, 2018
@CaMer0n CaMer0n added this to the e107 2.1.8 milestone Jan 28, 2018
CaMer0n added a commit that referenced this issue Jan 28, 2018
Fixes: #3015 Reimplement e_tree_model sorting in pure PHP
CaMer0n added a commit that referenced this issue Feb 3, 2018
Reimplement e_tree_model sorting in pure PHP (with pagination)
Fixes: #3015
Supersedes: #2929
Supersedes: #3016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

2 participants