Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trf support for http server #100

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Trf support for http server #100

merged 2 commits into from
Aug 30, 2024

Conversation

raakella1
Copy link
Contributor

  • Add trf auth verification support for http server.
  • Add restart server functionality in http server

@raakella1 raakella1 requested a review from yuwmao August 30, 2024 00:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.37705% with 26 lines in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (ec891d2) to head (371899f).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/http_server.cpp 46.66% 23 Missing and 1 partial ⚠️
src/lib/io_environment.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   45.26%   45.33%   +0.06%     
==========================================
  Files          54       54              
  Lines        4012     4059      +47     
  Branches      478      484       +6     
==========================================
+ Hits         1816     1840      +24     
- Misses       2065     2088      +23     
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuwmao
Copy link

yuwmao commented Aug 30, 2024

LGTM.

yuwmao added a commit to yuwmao/HomeObject that referenced this pull request Aug 30, 2024
yuwmao added a commit to yuwmao/HomeObject that referenced this pull request Aug 30, 2024
yuwmao added a commit to yuwmao/HomeObject that referenced this pull request Aug 30, 2024
@raakella1 raakella1 merged commit afdb876 into eBay:master Aug 30, 2024
12 checks passed
@raakella1 raakella1 deleted the trf branch August 30, 2024 22:25
xiaoxichen pushed a commit to eBay/HomeObject that referenced this pull request Sep 4, 2024
* Adaptive changes for HttpManager

Relevant changes: eBay/IOManager#100

* Remove http start logic

* fix UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants