Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude fatal errors from code coverage report #15

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

greensky00
Copy link
Contributor

  • Fatal errors that we must not reach cannot be verified by using
    functional tests.

  • Also excluded legacy snapshot type (i.e., raw_binary).

* Fatal errors that we must not reach cannot be verified by using
functional tests.

* Also excluded legacy snapshot type (i.e., `raw_binary`).
@codecov-io
Copy link

Codecov Report

Merging #15 into master will increase coverage by 1.134%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           master       #15       +/-   ##
============================================
+ Coverage   83.61%   84.744%   +1.134%     
============================================
  Files          55        55               
  Lines        3972      3920       -52     
============================================
+ Hits         3321      3322        +1     
+ Misses        651       598       -53

@greensky00 greensky00 merged commit e6ed6be into eBay:master Aug 10, 2019
xiaoxichen pushed a commit to xiaoxichen/NuRaft that referenced this pull request Jan 16, 2024
xiaoxichen pushed a commit to xiaoxichen/NuRaft that referenced this pull request Jan 16, 2024
* Upgrade nuraft

* v6.0.1

* Update logstore for test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants