Fix thread sanitizer issues #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No thread detaching: all background threads including Asio workers should be in control. * Changed the type of `raft_params` from `unique_ptr` to `shared_ptr`, as it can be dynamically changed and we should guarantee MVCC. * `ctx_` should use lock around `raft_params_`, to avoid data race. * Fixed some test issues.
JackyWoo
pushed a commit
to JackyWoo/NuRaft
that referenced
this pull request
Sep 30, 2022
xiaoxichen
pushed a commit
to xiaoxichen/NuRaft
that referenced
this pull request
Jan 16, 2024
* Make the internal build the modified version, not the committed. * Updated README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No thread detaching: all background threads including Asio workers
should be in control.
Changed the type of
raft_paramsfromunique_ptrtoshared_ptr,as it can be dynamically changed and we should guarantee MVCC.
ctx_should use lock aroundraft_params_, to avoid data race.Fixed some test issues.