feat(toggle-button): add toggle button #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtBlue
requested changes
Jun 20, 2023
ArtBlue
reviewed
Jun 20, 2023
|
Thanks Arthur, everything should be fixed now |
ArtBlue
reviewed
Jun 21, 2023
| @@ -89,7 +89,7 @@ export default { | |||
| }, | |||
| control: { type: "text" }, | |||
| description: | |||
| "Placement of the image within the given bounds using the CSS `background-position` property. Using this property will switch the image fit from `contain` to `cover`", | |||
| "Placement of the image within the given bounds using the CSS `background-position` property. Options include [keywords, lengths, and edge distances](https://developer.mozilla.org/en-US/docs/Web/CSS/background-position). Using this property will switch the image fit from `contain` to `cover`", | |||
|
@LuLaValva , this looks ready for merge. Can you just double check all the conversations and resolve them to make sure? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add toggle button from
ebayui-corefromskinContext
Must be tested in tandem with
^skin@16.3.0usingnpm linkScreenshots