fix(line-chart): adds renderTooltipOutside input to allow for renders in modal #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f448c62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LuLaValva
reviewed
Sep 24, 2024
mikehobi
reviewed
Sep 24, 2024
| @@ -40,6 +40,7 @@ interface LineChartInput | |||
| "cdn-highcharts-accessibility"?: string; | |||
| version?: string; | |||
| series: SeriesLineOptions | SeriesLineOptions[]; | |||
| outside?: boolean; | |||
There was a problem hiding this comment.
Since this "outside" property only pertains to the tooltip configuration, I'm wondering if this should be renamed to something like tooltipOutside or renderTooltipOutside... I'm not quite sure what would make the most sense
There was a problem hiding this comment.
I was struggling back and forth on that naming while working on this. I had renderTooltipOutside initially, and I think it makes sense to go back to that flag naming.
lorenzolevy
changed the title
agliga
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
outsideinput ontoebay-line-chart.Context
Prior to this PR, the
outsidehighcharts configuration hardcoded totruewould cause the tooltip to render relative to the whole page rather than to the modal window or chart render. Allowing clients to set this value allows proper rendering of the tooltip + chart in a modal window.References
#2271
Screenshots