-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-skin lasso flag #84
Conversation
I worked with @CestDiego on this PR this morning. It’s legit. Thanks for jumping on this, Diego! |
Thanks @CestDiego and @seangates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look great to me, but I want others to respond in the affirmative before we merge.
I know the name was discussed a bit earlier, but |
I agree with Yoni, |
Proposed names:
|
Personally, I think Are we intentionally leaving this out of the documentation? |
I expect we leave this out of the documentation. It is only pertinent in very specific cases. In fact, only one we know of. |
Let's go with |
@ianmcburnie sorry for the delay. I have changed the skinless flag to the |
Build failed, this time on something in the carousel. @yomed, can you look at it on Monday? |
Never mind. Reran the build. It was simply a timeout. |
@CestDiego Would ebayui-core/src/components/ebay-breadcrumb/browser.json Lines 3 to 4 in 0d54534
|
Description
Add condition to now load skin with each component if there is a flag present.
Context
Global Header ships their own scoped skin version and using ebayui-core components ships with their own unscoped skin code, this defeats the purpose of having a scoped skin version. This PR fixes that problem by letting Global Header import components without skin, and injecting their own scoped skin into then.
References
#75