acl add/delete code isn't handling external_ids correctly #124
Comments
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 5, 2021
acl add/delete code isn't handling "nil" for external_ids correctly Also, fix typo in name of oMapContians() to oMapContains() Signed-off-by: Andre Fredette <afredette@redhat.com>
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 6, 2021
Signed-off-by: Andre Fredette <afredette@redhat.com>
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 6, 2021
Signed-off-by: Andre Fredette <afredette@redhat.com> More testing. Signed-off-by: Andre Fredette <afredette@redhat.com>
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 6, 2021
Signed-off-by: Andre Fredette <afredette@redhat.com>
anfredette
changed the title
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 7, 2021
… correctly See eBay#124 for details Signed-off-by: Andre Fredette <afredette@redhat.com>
This was referenced Jan 7, 2021
|
I updated the description based on a discussion with @hzhou8 on the desired behavior. |
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 13, 2021
… correctly eBay#124 external_ids should be ignored while checking for duplicates in ACLAdd and matching in ACLDel The parameters that define a unique ACL for a given entity (logical switch or port group) are direction, match, and priority. The code currently also attempts to also use external_ids, but it should not. Signed-off-by: Andre Fredette <afredette@redhat.com>
anfredette
added a commit
to anfredette/go-ovn
that referenced
this issue
Jan 13, 2021
… correctly eBay#124 external_ids should be ignored while checking for duplicates in ACLAdd The parameters that define a unique ACL for a given entity (logical switch or port group) are direction, match, and priority. The code currently also attempts to also use external_ids, but it should not. Signed-off-by: Andre Fredette <afredette@redhat.com>
hzhou8
added a commit
that referenced
this issue
Jan 14, 2021
Fix issue #124: acl add/delete code isn't handling external_ids correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
external_ids should be ignored while checking for duplicates in ACLAdd and matching in ACLDel
The parameters that define a unique ACL for a given entity (logical switch or port group) are direction, match, and priority. The code currently also attempts to also use external_ids, but it should not.
The text was updated successfully, but these errors were encountered: