Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for homestore based replication to run correctly #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hkadayam
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1dc1e6a) 75.06% compared to head (be18e06) 75.15%.

Files Patch % Lines
src/proto/proto_service.cpp 61.11% 6 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   75.06%   75.15%   +0.09%     
==========================================
  Files          20       20              
  Lines         794      801       +7     
  Branches       91       90       -1     
==========================================
+ Hits          596      602       +6     
- Misses        136      137       +1     
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

szmyd
szmyd previously approved these changes Dec 13, 2023
@hkadayam hkadayam dismissed szmyd’s stale review December 13, 2023 18:22

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants