Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filter): evo updates #1502 #1528

Merged
merged 1 commit into from
Aug 2, 2021
Merged

feat(filter): evo updates #1502 #1528

merged 1 commit into from
Aug 2, 2021

Conversation

ianmcburnie
Copy link
Contributor

@ianmcburnie ianmcburnie commented Jul 30, 2021 •
edited
Loading

Closes #1502

  • Updates colours for evo.
  • Spotted an issue with filter-menu js that also needed fixing.
  • Adds a new primitive @color-text-primary which is more in line with design terminology

Currently focus states are still not passing a11y color contrast so we need another follow up to fix that issue (#1529)

Screenshots

Screen Shot 2021-07-30 at 12 32 38 PM
Screen Shot 2021-07-30 at 12 32 31 PM
Screen Shot 2021-07-30 at 12 31 28 PM

Screen Shot 2021-07-30 at 12 32 06 PM
Screen Shot 2021-07-30 at 12 31 58 PM
Screen Shot 2021-07-30 at 12 31 39 PM

@ianmcburnie ianmcburnie self-assigned this Jul 30, 2021
austingardner
austingardner approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@austingardner austingardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianmcburnie ianmcburnie merged commit 217a8a2 into 13.0.0 Aug 2, 2021
@ianmcburnie ianmcburnie deleted the 1502-filter-evo branch August 2, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingardner austingardner austingardner approved these changes

Assignees

@ianmcburnie ianmcburnie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianmcburnie @austingardner