fix(button): changed aria-live to be separate form aria-disabled hover #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtBlue
reviewed
Jan 21, 2022
|
Also running into some unsynced files when running build:
|
Yes. This was due to the hover pr. It's fixed on 13.4 |
agliga
force-pushed
the
1637-hover-color
branch
from
0f06cd6
to
358aa34
Compare
austingardner
approved these changes
Jan 24, 2022
| @@ -79,7 +79,7 @@ a.fake-btn--primary { | |||
| } | |||
|
|
|||
| /* show hover states only for non-disabled or non-loading state button */ | |||
| button.btn--primary:not([disabled]):not([aria-live="polite"][aria-disabled="true"]), | |||
| button.btn--primary:not([disabled]):not([aria-disabled="true"]), | |||
| a.fake-btn--primary[href] { | |||
| &:focus, | |||
| &:hover, | |||
There was a problem hiding this comment.
should we drop the active here (line 86)? I think maybe I should've with my last PR. Maybe could do in a separate PR if needed, but probably shouldn't be here. Other than that LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since partially disabled relies on
aria-disabledto disable hover, this code was picking up hover together witharia-live. Changed it so they're separate checks.References
#1637