Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast-dialog): secondary button hover issue #2104

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jul 27, 2023

Fixes #2092

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Fixed the hover and active states.

Notes

I found out that --color-state-information-hover used for the hover background doesn't exist. When I used the tokens for accent hover/active, it looked more like what it should have looked like all along. We can remove that if it's not relevant, but it seems to resolve all of the hover state issues to what was likely originally intended.

Screenshots

Before:
(see issue)

After:
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Jul 27, 2023
@ArtBlue ArtBlue requested review from agliga and LuLaValva July 27, 2023 20:49
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ArtBlue ArtBlue merged commit c1543d0 into 16.6.0 Jul 31, 2023
@ArtBlue ArtBlue deleted the 2092-toast-secondary-hover-unreadable branch July 31, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants