Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): added ai tokens #2145

Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat(tokens): added ai tokens #2145

merged 1 commit into from
Sep 15, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Aug 30, 2023

Fixes #2122

  • This PR contains CSS changes
  • This PR does not contain CSS changes (It contains token changes only, css changes are on demo page only)

Description

  • Added AI tokens, with gradients

Notes

  • Had to use background instead of background-color for tokens demo part because gradients dont work with background-color
  • Dark mode colors are the same as light mode.

Screenshots

Screenshot 2023-08-30 at 11 49 18 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. I do have some questions though. In the design docs, I'm only seeing these used in icons, but the icons are going to be -colored and not dynamic and would not need these. Where else will they be used?

@agliga
Copy link
Contributor Author

agliga commented Aug 31, 2023

The changes look fine. I do have some questions though. In the design docs, I'm only seeing these used in icons, but the icons are going to be -colored and not dynamic and would not need these. Where else will they be used?

These can be used by teams. We're simply providing those variables for them to be able to use them in their app. Like we do for the scrim tokens.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agliga agliga merged commit b43959a into 16.7.0 Sep 15, 2023
2 checks passed
@agliga agliga deleted the ai-tokens branch September 15, 2023 14:38
@agliga agliga restored the ai-tokens branch September 20, 2023 23:59
@agliga agliga deleted the ai-tokens branch October 25, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants