Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(donut-chart): new module #2314

Closed
wants to merge 14 commits into from

Conversation

mikehobi
Copy link
Contributor

Fixes #1956

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

This PR adds donut-chart and chart-legend styling and documentation

Notes

Our implementation in eBayUI uses Highcharts

Screenshots

Donut Chart

Dark Mode

image

Light Mode

image

Chart Legend

Dark Mode

image

Light Mode

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 9e01ac7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikehobi mikehobi changed the base branch from master to 17.4.0 April 22, 2024 18:44
@agliga agliga deleted the branch eBay:17.4.0 April 29, 2024 16:16
@agliga agliga closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-visualization: donut chart
3 participants