Color: updated grey colour palette #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcburnie
added
blocking: yes
agliga
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580
After speaking with design team it was decided it's best to shuffle in the new gray colour now.
Most of the mappings remained fairly close (e.g.
#c8c8c8;to#c7c7c7;). However, the old#6e6e6edidn't really have a consistent mapping. Sometimes I have had to map it to#a2a2a2and sometimes to#767676(especially in the cases where there are different of shades of grey going on, like carousel dots, textbox placeholders, dropdowns, etc).Hopefully I've got these right. I'm not too concerned if not as we will be sweeping through these colours again for ds6.5.
Old scheme
New scheme