feat: attribute whitelist #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanPiercey
force-pushed
the
attribute-whitelist
branch
3 times, most recently
from
064bd72
to
bd5e2ca
Compare
feat: sort attributes and css properties BREAKING CHANGE: snapshot output has changed
DylanPiercey
force-pushed
the
attribute-whitelist
branch
from
bd5e2ca
to
2d5e0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches the attribute preserving mechanism to use a whitelist for the html namespace and a blacklist for other namespaces.
Motivation and Context
The previous implementation of checking for computed style changes caused by each attribute caused too many false negatives. It also did not properly handle stateful properties such as
input value. This new solutions handles all known attributes that effect visibility and instead checks for their property to grab the most current value.Checklist: