EPT-2965: Add authentication endpoints #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citin
requested review from
a team,
k4th,
unabris and
kengallego
and removed request for
a team
k4th
approved these changes
Sep 3, 2024
unabris
reviewed
Sep 6, 2024
Comment on lines
49
to
55
| it 'sends a post request with the correct parameters' do | ||
| # client.change_username( | ||
| # user_id, | ||
| # user_password, | ||
| # new_name | ||
| # ) | ||
| end |
There was a problem hiding this comment.
I would leave the tests like follows (I just put one example):
# client.change_username(
# user_id,
# user_password,
# new_name
# )
it 'sends a post request with the correct parameters'I believe that writing an it statement without a block displays a "Pending" message when running the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.