Fix update variation properties #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of variation properties by updating the data structure and processing methods. The changes ensure that array-type variation properties are properly camelized and processed when making API calls.
- Enhanced
camelize_keysutility to handle arrays recursively, not just hashes - Updated
update_variation_propertiesmethod documentation to reflect array parameter type - Removed redundant
patchmethod from connection concerns
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/beyond_api/utils.rb | Enhanced camelize_keys to recursively process arrays in addition to hashes |
| lib/beyond_api/services/product_management/product.rb | Updated parameter documentation and example for variation properties |
| lib/beyond_api/concerns/connection.rb | Removed duplicate patch method implementation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.