-
Notifications
You must be signed in to change notification settings - Fork 115
Add support for constraints on nested fields. #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @thowimmer , thank you for the contribution! As far as I can see, this was already possible before using the
This is how we are using it so far. Your change certainly makes this more convenient! |
Reading the docs of
|
Hi @ozscheyge,
Yes I actually saw that. I was not sure whether the visibility of the other methods is itentional. But I guess that's the case after having this conversation:-)
I totally agree. I was expecting this method to behave like I implemented it in this PR. However - you judge whether this is what you want or not. I'm also fine to use your proposed solution with the
Yes good catch ! Thanks :-) I will refactor it to I leave it up to you whether you'd like this feature to be merged or not :-) |
I'd leave it open for further feedback/opinions. If there are no objections, it should be integrated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. LGTM
Hi all,
I added support for constraints on nested fields.
The support has been implemented by simply choosing the last JSON path element as the bean property name:
someNestedObject.someField -> someField = bean property name
someField -> someField = bean property name