Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21351] Refactor TopicDataType #375

Merged
merged 7 commits into from
Jul 18, 2024
Merged

[21351] Refactor TopicDataType #375

merged 7 commits into from
Jul 18, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 12, 2024

Description

Implementation of XCDR introduces new functions in TopicDataType class. But the old one remained. This PR removes them before launching the major version 3, and also performs additional refactorings:

  • Change method names to snake_case and have more meaningful names.
  • Change arguments from pointer to reference where applicable
  • Use std::string instead of char* on name getters and setters

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Remove old TopicDataType functions [21351] Remove old TopicDataType functions Jul 12, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
MiguelCompany previously approved these changes Jul 17, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
MiguelCompany previously approved these changes Jul 17, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany MiguelCompany changed the title [21351] Remove old TopicDataType functions [21351] Refactor TopicDataType Jul 18, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 18, 2024
@richiware richiware merged commit dd8aa30 into master Jul 18, 2024
4 checks passed
@richiware richiware deleted the feature/21349 branch July 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants