Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20566] Migrate classes from include/fastrtps to fastdds #726

Merged
merged 3 commits into from
Mar 25, 2024
Merged

[20566] Migrate classes from include/fastrtps to fastdds #726

merged 3 commits into from
Mar 25, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Mar 12, 2024 •
edited by EduPonz
Loading

Description

This PR migrates the following classes from include/fastrtps to fastdds:

  • IPLocator.h
  • md5.h

Related implementation PR:

Contributor Checklist

  • N/A Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf
Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps …
dcf3237 
…to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added this to the v3.0.0 milestone Mar 12, 2024
@elianalf elianalf mentioned this pull request Mar 12, 2024
Merged
5 tasks
EduPonz
EduPonz suggested changes Mar 13, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use google include order

@elianalf
Refs #20566: Reorder following google style
8fea622 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf requested a review from EduPonz March 13, 2024 07:14
@EduPonz
Copy link

EduPonz commented Mar 13, 2024

@richiprosima please test this

@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@elianalf
Refs #20566: Fix spelling errors after rebase
f8c5f7f 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@EduPonz EduPonz merged commit c46a4d8 into 3.0.x-devel Mar 25, 2024
3 checks passed
@EduPonz EduPonz deleted the feature/migrate_classes_from_include_fastrtps branch March 25, 2024 11:30
EduPonz pushed a commit that referenced this pull request Mar 25, 2024
@elianalf @EduPonz
Migrate classes from include/fastrtps to fastdds (#726)
8068fb6 
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
richiware pushed a commit that referenced this pull request Apr 18, 2024
@elianalf @richiware
Migrate classes from include/fastrtps to fastdds (#726)
91d940e 
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
EduPonz pushed a commit that referenced this pull request Apr 24, 2024
@elianalf @EduPonz
Migrate classes from include/fastrtps to fastdds (#726)
a6dd808 
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 9, 2024
@elianalf @EduPonz
Migrate classes from include/fastrtps to fastdds (#726)
ad379bf 
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 13, 2024
@elianalf @EduPonz
Migrate classes from include/fastrtps to fastdds (#726)
9a145d4 
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 14, 2024
@elianalf @EduPonz
Migrate classes from include/fastrtps to fastdds (#726)
7fb954f 
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso left review comments

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @EduPonz @JesusPoderoso