Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21136] Add XML configuration for FlowControllerDescriptor to 2.x #793

Merged
merged 3 commits into from
Jun 6, 2024
Merged

[21136] Add XML configuration for FlowControllerDescriptor to 2.x #793

merged 3 commits into from
Jun 6, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jun 5, 2024 •
edited by JesusPoderoso
Loading

Description

This PR is a backport from #782 to 2.x. It adds the XML documentation for flow controller descriptors.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL
Refs #21136: Add XML Flow Controller Descriptors documentation
27ebeff 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v2.14.2 milestone Jun 5, 2024
@Mario-DL Mario-DL mentioned this pull request Jun 5, 2024
Merged
14 tasks
JesusPoderoso
JesusPoderoso requested changes Jun 5, 2024
View reviewed changes
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/XMLTester.xml Show resolved Hide resolved
@Mario-DL
Refs #21136: Apply rev
3494bc6 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21136: Fix XML repr.
1e88274 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

JesusPoderoso
JesusPoderoso approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Copy link
Member

EduPonz commented Jun 6, 2024

@Mergifyio backport 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Jun 6, 2024 •
edited
Loading

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit f3f4f0e into 2.14.x Jun 6, 2024
2 checks passed
@EduPonz EduPonz deleted the feature/2.x/21054 branch June 6, 2024 10:49
This was referenced Jun 6, 2024
Merged
Open
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
@Mario-DL @mergify
Add XML configuration for FlowControllerDescriptor to 2.x (#793)
dba3223 
* Refs #21136: Add XML Flow Controller Descriptors documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Apply rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Fix XML repr.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit f3f4f0e)
This was referenced Jun 6, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
@Mario-DL @mergify
Add XML configuration for FlowControllerDescriptor to 2.x (#793)
8607995 
* Refs #21136: Add XML Flow Controller Descriptors documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Apply rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Fix XML repr.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit f3f4f0e)

# Conflicts:
#	docs/fastdds/use_cases/large_data/large_data.rst
@mergify mergify bot mentioned this pull request Jun 6, 2024
Open
8 tasks
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
@Mario-DL @mergify
Add XML configuration for FlowControllerDescriptor to 2.x (#793)
1a9d3b6 
* Refs #21136: Add XML Flow Controller Descriptors documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Apply rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Fix XML repr.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit f3f4f0e)

# Conflicts:
#	code/XMLTester.xml
#	docs/fastdds/use_cases/large_data/large_data.rst
@mergify mergify bot mentioned this pull request Jun 6, 2024
Merged
8 tasks
@Mario-DL Mario-DL mentioned this pull request Jun 7, 2024
Merged
7 tasks
Mario-DL added a commit that referenced this pull request Jun 27, 2024
@mergify @Mario-DL
Add XML configuration for FlowControllerDescriptor to 2.x (#804)
c94b258 
* Add XML configuration for FlowControllerDescriptor to 2.x (#793)

* Refs #21136: Add XML Flow Controller Descriptors documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Apply rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Fix XML repr.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit f3f4f0e)

# Conflicts:
#	code/XMLTester.xml
#	docs/fastdds/use_cases/large_data/large_data.rst

* Refs #21244: Solve conflicts and remove thread settings

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21244: Complete flow controller descirptor

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21244: Nit

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
EduPonz pushed a commit that referenced this pull request Jul 12, 2024
@mergify @Mario-DL
Add XML configuration for FlowControllerDescriptor to 2.x (#793) (#802)
17ee9fb 
* Refs #21136: Add XML Flow Controller Descriptors documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Apply rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Fix XML repr.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit f3f4f0e)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mario-DL @JesusPoderoso @EduPonz