Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21054] Add XML configuration for FlowControllerDescriptor #782

Merged
merged 4 commits into from
May 31, 2024
Merged

[21054] Add XML configuration for FlowControllerDescriptor #782

merged 4 commits into from
May 31, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented May 24, 2024 •
edited by JesusPoderoso

Description

This PR adds the XML configuration for FlowControllerDescriptor.

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v3.0.0 milestone May 24, 2024
@Mario-DL Mario-DL mentioned this pull request May 24, 2024
Merged
12 tasks
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test_3 this

I think CI won't pass until Fast DDS PR gets merged

JesusPoderoso

This comment was marked as outdated.

Sign in to view

@Mario-DL
Refs #21054: Add XML flow_controller_descriptos docs
4399785 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21054: Apply rev
bff6445 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21054: Linter
06c3a4e 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
JesusPoderoso
JesusPoderoso previously approved these changes May 27, 2024
View reviewed changes
@JesusPoderoso
Copy link
Contributor

@richiprosima please test_3 this

@Mario-DL
Refs #21054: Extend flow controller descriptor with a thread settings…
c504abc 
… conf

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 this

@EduPonz EduPonz merged commit 916905d into master May 31, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21054 branch May 31, 2024 10:42
@Mario-DL Mario-DL mentioned this pull request Jun 5, 2024
Merged
8 tasks
This was referenced Jun 6, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso left review comments

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mario-DL @JesusPoderoso @EduPonz