Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21136] Add XML configuration for FlowControllerDescriptor to 2.x (backport #793) #802

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[21136] Add XML configuration for FlowControllerDescriptor to 2.x (backport #793) #802

merged 1 commit into from
Jul 12, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 6, 2024

Description

This PR is a backport from #782 to 2.x. It adds the XML documentation for flow controller descriptors.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.
This is an automatic backport of pull request #793 done by [Mergify](https://mergify.com).

@Mario-DL @mergify
Add XML configuration for FlowControllerDescriptor to 2.x (#793)
dba3223 
* Refs #21136: Add XML Flow Controller Descriptors documentation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Apply rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21136: Fix XML repr.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit f3f4f0e)
@mergify mergify bot mentioned this pull request Jun 6, 2024
Merged
8 tasks
@JesusPoderoso JesusPoderoso added this to the v2.13.6 milestone Jun 6, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 6, 2024
Merged
14 tasks
@Mario-DL Mario-DL mentioned this pull request Jun 7, 2024
Merged
7 tasks
@Mario-DL Mario-DL mentioned this pull request Jun 27, 2024
Merged
8 tasks
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso added implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS and removed implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS labels Jul 10, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 11, 2024 13:29
JesusPoderoso
JesusPoderoso approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green GitHub CI

@EduPonz EduPonz merged commit 17ee9fb into 2.13.x Jul 12, 2024
4 of 5 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-793 branch July 12, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v2.13.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JesusPoderoso @EduPonz @Mario-DL