Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: generate ROS2 compatible type naming #22

Merged

Conversation

TSC21
Copy link
Contributor

@TSC21 TSC21 commented Mar 26, 2020

Fixes #19. @LuisGP thank you for the tips. Please check if this solution makes sense to you:

  1. -typeros2 option sets m_type_ros2 to true, which is defined in the Context;
  2. If isGenerateTypesROS2 is true, meaning m_type_ros2, then it's used a scoped name generated from the IDL parser, which has the required valid structure to be used in the ROS2 context.

Requires eProsima/IDL-Parser#39 to be merged first.

@LuisGP
Copy link
Contributor

LuisGP commented Mar 27, 2020

@TSC21 Please, update the IDL-Parser submodule and I'll approve the PR.

@TSC21
Copy link
Contributor Author

TSC21 commented Mar 27, 2020

@TSC21 Please, update the IDL-Parser submodule and I'll approve the PR.

Ah yes of course. Will do

Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the submodule IDL parser to the new generated commit after the squash (generated when merging the PR)

@richiware
Copy link
Member

Please, update IDL parser submodule to the master's commit.

Copy link
Contributor

@LuisGP LuisGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuisGP LuisGP merged commit 642e192 into eProsima:master Mar 27, 2020
@TSC21 TSC21 deleted the feature/generate_ROS2_compatible_typename branch March 27, 2020 11:11
@TSC21
Copy link
Contributor Author

TSC21 commented Mar 27, 2020

@LuisGP @richiware thank you both. This will definitely improve the experience for people using standalone Fast-RTPS apps linked in the same DDS domain as ROS2 nodes.

Before you do a release, I would like to add as a feature an option to install the script and binary system wide (in /usr/local for example), making a new PR. Is that something you can wait for or are you pushing to a 1.0.4 release already?

@LuisGP
Copy link
Contributor

LuisGP commented Mar 27, 2020

@LuisGP @richiware thank you both. This will definitely improve the experience for people using standalone Fast-RTPS apps linked in the same DDS domain as ROS2 nodes.

Before you do a release, I would like to add as a feature an option to install the script and binary system wide (in /usr/local for example), making a new PR. Is that something you can wait for or are you pushing to a 1.0.4 release already?

@MiguelCompany this message is for you :P.

@TSC21
Copy link
Contributor Author

TSC21 commented Apr 1, 2020

@MiguelCompany @LuisGP @richiware are you planning to document this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Set typename by argument
3 participants