High order element related enhancement #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modifying RemoveDuplicates
- Modifying RemoveDuplicates - Now temp array is not allocatable - The code may break if unallocatable array is send --- <details open="true"><summary>Generated summary (powered by <a href="https://app.graphite.dev">Graphite</a>)</summary> > ## TL;DR > This pull request modifies the `AppendUtility.F90` and `IntegerUtility@Methods.F90` files. It introduces changes to the `Expand` interface and adds a new implementation for removing duplicates in the `RemoveDuplicates_1.inc` file. > > ## What changed > - In the `AppendUtility.F90` file, the `Expand` interface is modified to include new subroutines for expanding integer and real vectors. > - In the `IntegerUtility@Methods.F90` file, the `RemoveDuplicates_1a`, `RemoveDuplicates_1b`, `RemoveDuplicates_1c`, and `RemoveDuplicates_1d` procedures are modified to use the new implementation in the `RemoveDuplicates_1.inc` file. > > ## How to test > To test the changes, follow these steps: > 1. Compile and build the project. > 2. Run the relevant test cases that use the `Expand` interface and the `RemoveDuplicates` procedures. > 3. Verify that the expanded vectors and removed duplicates are correct. > > ## Why make this change > - The changes to the `AppendUtility.F90` file introduce new subroutines for expanding integer and real vectors, which can be useful in various scenarios. > - The modifications to the `IntegerUtility@Methods.F90` file update the `RemoveDuplicates` procedures to use a new implementation in the `RemoveDuplicates_1.inc` file, potentially improving the efficiency and accuracy of removing duplicates in integer vectors. </details>
- Adding append method for appending three vectors of real or integers.
- Adding append method for appending three vectors of real or integers.
- Adding FacetConnectivity and EdgeConnectivity methods
- Adding FacetConnectivity and EdgeConnectivity methods
- Adding GetEdgeConnectivity - Adding GetFaceConnectivity
- Adding GetEdgeConnectivity - Adding GetFaceConnectivity
Updates in Reference Element Adding FaceConnectivity and Edge connectivity methods --- <details open="true"><summary>Generated summary (powered by <a href="https://app.graphite.dev">Graphite</a>)</summary> > ## TL;DR > This pull request adds interfaces and module procedures for reallocating multidimensional arrays of different data types in Fortran. > > ## What changed > - Added interfaces for reallocating arrays of real numbers and integers with different dimensions and data types. > - Defined module procedures for reallocating arrays of different data types (REAL64, REAL32, INT64, INT32, INT16, INT8). > - Included interfaces for reallocating arrays with dimensions ranging from 1D to 7D. > - Implemented subroutines for reallocating arrays based on input parameters. > > ## How to test > 1. Compile the Fortran file containing the ReallocateUtility module. > 2. Use test cases to call the different interfaces and module procedures for reallocating arrays. > 3. Verify that the arrays are reallocated correctly based on the input parameters. > 4. Check for any errors or warnings during compilation and testing. > > ## Why make this change > - Enhances the functionality of the ReallocateUtility module by adding support for reallocating arrays of various data types and dimensions. > - Provides a more flexible and efficient way to manage memory allocation for multidimensional arrays in Fortran programs. > - Improves code readability and maintainability by organizing the reallocation procedures into separate interfaces and module procedures. </details>
- Minor updates in ReferenceQuadrangle_Method - Updating face connectivity in hexahedron and tetrahedron
Updates in ReferenceElements - Minor updates in ReferenceQuadrangle_Method, Adding HelpFaceData_Quadrangle, Adding FaceShapeMetaData_Quadrangle - Updating face connectivity in hexahedron and tetrahedron
### TL;DR This pull request includes the addition of the 'GetElementIndex' method in the `Geometry` module. This new method returns the index of an element based on its topology. ### What changed? The changes can be noted in 'src/modules/Geometry/src/ReferenceElement_Method.F90' and 'src/submodules/Geometry/src/ReferenceElement_Method@GeometryMethods.F90'. A new function, 'GetElementIndex', has been added which returns the index of geometric elements like Point, Line, Triangle, Quadrangle, Tetrahedron, Hexahedron, Prism, and Pyramid based on their type. ### How to test? To validate these updates, build the project and validate that the new method correctly returns the expected indices when called with different geometric shapes. ### Why make this change? This change was needed as there was no method present earlier to retrieve the index of a geometric element based on its type. Hence, this new method 'GetElementIndex' would improve the functionality of the Geometry module. ---
Adding GetEdgeConnectivity.
Adding TotalEntities_Tetrahedron
Adding TotalEntities_Triangle method
…from-elem-type Adding FaceConnectivity methods to 3D elems
Minor fixes
vickysharma0812
deleted the
EASIFEM-3-Create-FacetElements-from-elemType
branch
vickysharma0812
restored the
EASIFEM-3-Create-FacetElements-from-elemType
branch
vickysharma0812
deleted the
EASIFEM-3-Create-FacetElements-from-elemType
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds partial support for higher order elements. This is a work in progress.