-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function naming should be tweaked according to community consensus #99
Comments
Hi there, according to this collection of bits the pkgsrc seems to be the most generic convention (albeit more verbose than needed in eb case). Check it out, these are Makefile targets really:
|
Hi there, I recommend we make this a top priority issue for coming week, since it affects too many things:
Adopting the style has one obvious advantage: when people will need to make extensions to easybuild for the various steps (esp. as regards pre- & post- functions), there is established knowledge about what works well and how; and also what has been tried elsewhere without great results and should rather be avoided... |
I broke these down, you're welcome to add remarks on this. Note: work-in-progress
|
Note: work-in-progress; FIXME
|
related discussion on possible function prefixbtw. what if we had to prepend these functions with something to make them a family? so, here is another lingo-related finding: macports: phases So, for me the prefix should be either Stage_ or Phase_ or '' ... what are your preferences? |
Now, we're using 'step', i.e. we run every step of the build/install process using a There's clearly no consensus on that (5 tools, 4 different lingos), so why change it? |
@stdweird, @JensTimmerman: Can you guys check the proposal made in easybuilders/easybuild#99 (comment), and let us know whether you have any objections to this? If not, I'd like to make a pull request for these changes this week. |
a few remarks depend vs robot: robot is a runtime option, but it sort of does what depend suggests. depend is like the auto-robot (ie just build all deps always) i think at some point we should have a deinstall (some people might want to cleanup software, eg because they run out of space): check is tool/version is a dependency of something else; if not, remove module file and install dir |
I agree with Stijn, adding all these function to easyblock, and calling them in runstep now will allow for greater flexibility when needed in the future. |
Hi, On Thu, Aug 23, 2012 at 11:41 AM, Jens Timmerman
In fact, doing so and homogenizing their pre/post/during calling It would be useful to allow for extensions across all functions like: This gives freedom to other developers to override behavior |
btw.
Some implementations, like ports, seem to put it after checksum; OTOH, doing so masks dependency issues; what is your stance? |
I worked out the function renaming scheme for this issue on the whiteboard at our lab, together with the required changes for # 136 and #90. http://users.ugent.be/~kehoste/function_renaming_scheme.jpg Don't worry if it doesn't make sense to you, it does to me. I'll be implementing it during the next couple of days in https://github.com/boegel/easybuild/tree/99_function_renaming, and I'll issue a pull request when it's done. |
For folow up on this, see #272 |
implement function renaming scheme (see issue #99)
…as per issue easyblocks/easybuilders#99 Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
add quotes around setenv definitions in modulefiles & define authors as per issue easyblocks/#99
Some of the functions (mainly the ones being called in the
build
function ofbuild.py
) could be named better.E.g.,
make_install
should be changed toinstall
,make
tobuild
, etc.@fgeorgatos will study if there's a consensus on a naming scheme by looking at porting systems (e.g., MacPorts).
The text was updated successfully, but these errors were encountered: