Skip to content

Remove unused register method from CalculatorFactory #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

Remove unused register method from CalculatorFactory #90

merged 1 commit into from
Sep 5, 2025

Conversation

AndrewSazonov
Copy link
Member

Fixes #17

@AndrewSazonov AndrewSazonov added this to the New API Stabilization milestone Sep 3, 2025
@AndrewSazonov AndrewSazonov added the [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) label Sep 3, 2025
rozyczko
rozyczko approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now the choice is hardcoded? It's OK, since it's a step towards corelib support.

@AndrewSazonov AndrewSazonov merged commit df880a4 into develop Sep 5, 2025
3 checks passed
@AndrewSazonov AndrewSazonov deleted the 17-remove-the-register_minimizer-method-from-calculatorfactory branch September 5, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozyczko rozyczko rozyczko approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
[scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)
Projects
New EasyDiffractionLib
Status: Done
Milestone
New API Stabilization
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewSazonov @rozyczko