Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more winsorizing options? #47

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

more winsorizing options? #47

wants to merge 14 commits into from

Conversation

mattansb
Copy link
Member

@mattansb mattansb commented Jan 4, 2022

@IndrajeetPatil Would you be open to one or more of the following while I'm at it:

  • Allow hard values for windzorizing, with threshold = c(bottom, top)?
  • For factors, can combine levels with less than threshold% observations? Is that weird?

@IndrajeetPatil
Copy link
Member

Can you please create an issue about this where we can discuss this, and then you link this PR to it? That way we will have a written record in issues about what motivated this change. :)

Thanks!

@codecov-commenter

This comment was marked as off-topic.

@strengejacke
Copy link
Member

we could add select helpers here, too. See ranktransform() etc.

@strengejacke strengejacke mentioned this pull request Mar 22, 2022
7 tasks
@IndrajeetPatil
Copy link
Member

@mattansb Do you plan to work on this any time soon?

#133 is waiting on this PR.

@mattansb
Copy link
Member Author

My deadline for sending out my dissertation is 30/9, so before that I won't have time for anything other than a patch here or there...

@IndrajeetPatil IndrajeetPatil marked this pull request as draft June 12, 2022 14:47
@IndrajeetPatil
Copy link
Member

Cool. Marking this as a draft PR then. We can revisit this after #133.

rempsyc added a commit to rempsyc/datawizard that referenced this pull request Jun 25, 2022
IndrajeetPatil pushed a commit that referenced this pull request Jun 27, 2022
* addresses #177 & #49 & #47 for winsorizing based on the MAD

* forgot to push updated documentation

* new argument "method", updated NEWS, resolved failed test, #179

* update winsorize.numeric

added raw method

made the code easier to maintain by modularizing it

made doc more explicit about the methods

updated examples to visualize the effect

update NEWS

* minor modifications to docs

* removed tidyr from Suggests, replaced `tidyr::pivot_longer` with `datawizard::data_to_long` in vignette

* added new tests for new winsorization methods, insight::format_message(), data[] <- lapply...

Co-authored-by: RemPsyc <RemPsyc@users.noreply.github.com>
Co-authored-by: Mattan S. Ben-Shachar <matanshm@post.bgu.ac.il>
@etiennebacher
Copy link
Member

@mattansb Do you think you will have time to finish this PR for a release in the next few weeks?

@mattansb
Copy link
Member Author

Oh, I totally forgot about this... um, probably not...

@etiennebacher
Copy link
Member

Ok, I close it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants