-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document r_rbs SEs #341
Document r_rbs SEs #341
Conversation
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 79.82% 79.79% -0.03%
==========================================
Files 54 54
Lines 3335 3335
==========================================
- Hits 2662 2661 -1
- Misses 673 674 +1
Continue to review full report at Codecov.
|
Yes, sounds good! |
@bwiernik I'll run these sims and get back to you. Some checks seem to be failing related to |
@strengejacke On some further testing, it looks like mathjaxr would need to be in Imports, not Suggests. Are you still okay with adding it? I think it's worth it to make the equations more readable in the place where most users will see them. |
I say no - I think having Thanks for your work on this and your very detailed comments :) |
Closes #336
Note that there appears to be errors in the formulas JASP is using. @mattansb Can you run some simulations like I describe in #336 and see if we need to modify the formulas to divide the SEs by
(1 - r_rbs^2)
?Also, it would be nice typeset equations and math symbols in the HTML help using Mathjax for pretty equations, rather than simply omitting the symbols as is currently done. It just takes adding
mathjaxr
to Suggests (no downstream dependencies). Does that sound good to you @mattansb @strengejacke ?