Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document r_rbs SEs #341

Merged
merged 7 commits into from
May 29, 2021
Merged

Document r_rbs SEs #341

merged 7 commits into from
May 29, 2021

Conversation

bwiernik
Copy link
Contributor

Closes #336

Note that there appears to be errors in the formulas JASP is using. @mattansb Can you run some simulations like I describe in #336 and see if we need to modify the formulas to divide the SEs by (1 - r_rbs^2) ?

Also, it would be nice typeset equations and math symbols in the HTML help using Mathjax for pretty equations, rather than simply omitting the symbols as is currently done. It just takes adding mathjaxr to Suggests (no downstream dependencies). Does that sound good to you @mattansb @strengejacke ?

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #341 (84e6118) into main (feb1694) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   79.82%   79.79%   -0.03%     
==========================================
  Files          54       54              
  Lines        3335     3335              
==========================================
- Hits         2662     2661       -1     
- Misses        673      674       +1     
Impacted Files Coverage Δ
R/rank_effectsizes.R 82.91% <100.00%> (ø)
R/interpret_bf.R 95.45% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb1694...84e6118. Read the comment docs.

@strengejacke
Copy link
Member

Does that sound good to you @mattansb @strengejacke ?

Yes, sounds good!

@mattansb
Copy link
Member

@bwiernik I'll run these sims and get back to you.

Some checks seem to be failing related to mathjaxr...

@bwiernik
Copy link
Contributor Author

@strengejacke On some further testing, it looks like mathjaxr would need to be in Imports, not Suggests. Are you still okay with adding it? I think it's worth it to make the equations more readable in the place where most users will see them.

@mattansb
Copy link
Member

I say no - I think having \eqn{pretty}{ugly} is as good as we're gonna get here for now :/

Thanks for your work on this and your very detailed comments :)

@bwiernik bwiernik merged commit b818553 into main May 29, 2021
@bwiernik bwiernik deleted the rbs branch May 29, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate SE formulas for the rank biserial correlation
4 participants