Skip to content

Commit

Permalink
reduce workflows on main
Browse files Browse the repository at this point in the history
  • Loading branch information
@strengejacke
strengejacke committed Apr 26, 2024
1 parent 8766054 commit ba37896
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 24 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/R-CMD-check-hard.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
# never used to avoid accidentally restoring a cache containing a suggested
# dependency.
on:
push:
branches: [main, master]

This comment has been minimized.

Sign in to view

Copy link
@IndrajeetPatil

IndrajeetPatil Apr 26, 2024

Member

In easystats/workflows#60 you say:

Given that we usually create PRs before changes enter the main branch, wouldn't it be enough to just run a few checks on push/main, and run all checks only on pull-request/main?

And now you have pushed all these changes to workflows directly to the default branch. 😞

This is not at all what we wanted. I had also created a PR in the morning to give a hint for a direction we could take: easystats/see#340

Anyway, I am not going to put any energy into this anymore: each maintainer can do whatever they want with workflows in the repos they are maintaining. It's hopeless to expect that all repos will follow the same standard for quality assurance.

This comment has been minimized.

Sign in to view

Copy link
@strengejacke

strengejacke Apr 26, 2024

Author Member

This is not at all what we wanted.

Not sure I understand. For PRs, we run all checks to see if everything is ok, and then we merge into main. So we don't need to repeat the complete test machinery for main again?
pull_request:
branches: [main, master]

Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/R-CMD-check-main.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
#
# NOTE: This workflow is overkill for most R packages and
# check-standard.yaml is likely a better choice.
# usethis::use_github_action("check-standard") will install it.
on:
push:
branches: [main, master]

name: R-CMD-check

jobs:
R-CMD-check:
uses: easystats/workflows/.github/workflows/R-CMD-check-main.yaml@main
2 changes: 0 additions & 2 deletions .github/workflows/R-CMD-check-strict.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
#
# R CMD Check will fail on a `NOTE`.
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/R-CMD-check.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
# check-standard.yaml is likely a better choice.
# usethis::use_github_action("check-standard") will install it.
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/check-all-examples.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#
# This workflow helps find such failing examples that need to be modified.
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/check-link-rot.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/check-spelling.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/check-styling.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/check-test-warnings.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Running tests with options(warn = 2) to fail on test warnings
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/check-vignette-warnings.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Running tests with options(warn = 2) to fail on test warnings
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/html-5-check.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/pkgdown-no-suggests.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test-coverage.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

Expand Down

0 comments on commit ba37896

Please sign in to comment.