Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing in random order (again) #757

Closed
IndrajeetPatil opened this issue Apr 13, 2023 · 6 comments · Fixed by #758
Closed

Tests failing in random order (again) #757

IndrajeetPatil opened this issue Apr 13, 2023 · 6 comments · Fixed by #758
Assignees
Labels
3 investigators ❔❓ Need to look further into this issue Low priority 😴 This issue can be easily workaround or happens only in edge cases

Comments

@IndrajeetPatil
Copy link
Member

@etiennebacher Do you want to have a look at it?

@etiennebacher
Copy link
Member

I use the same script and the same seed but I don't have the same file order. For example, here:

  • the first is test-ivreg.R but mine is test-ivreg_AER.R
  • then it's the same until test-format_table.R which for me is test-format_table_ci.R
  • etc.

So I can't reproduce all of these failures

@IndrajeetPatil
Copy link
Member Author

Hmm, maybe because you are on Windows, and we run the check on Ubuntu for our CI/CD. On macOS, I can reproduce two failures.

I have changed the workflow so that the tests run on Windows. Let's see if we still see any test failures.

@IndrajeetPatil
Copy link
Member Author

Yeah, failures are also seen on Windows: https://github.com/easystats/insight/actions/runs/4697252164/jobs/8328125120

Note that the seed is going to be different for each run.

@etiennebacher
Copy link
Member

etiennebacher commented Apr 14, 2023

Hmm, maybe because you are on Windows, and we run the check on Ubuntu for our CI/CD. On macOS, I can reproduce two failures.

The problem is not due to this, it's that before running the tests I can't get the same order as you even if I use exactly the same seed (and I don't know why)

@strengejacke
Copy link
Member

I see this warning:

Package logistf is loaded and breaks mmrm::mmrm() (1)

@etiennebacher
Copy link
Member

It's not a warning, it's just a skip message. It's because of namespace conflict, cf https://stackoverflow.com/questions/72533745/loading-logistf-breaks-mcmcglmm/72536046

I made a PR upstream but no answer so far georgheinze/logistf#54

@strengejacke strengejacke added Low priority 😴 This issue can be easily workaround or happens only in edge cases 3 investigators ❔❓ Need to look further into this issue labels May 2, 2023
strengejacke added a commit that referenced this issue Sep 18, 2023
* Tests failing in random order (again)
Fixes #757

* fix

* fix

* fix styling

---------

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 investigators ❔❓ Need to look further into this issue Low priority 😴 This issue can be easily workaround or happens only in edge cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants