Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect multivariate vgams/vglms #843

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Detect multivariate vgams/vglms #843

merged 8 commits into from
Jan 30, 2024

Conversation

B0ydT
Copy link
Contributor

@B0ydT B0ydT commented Jan 24, 2024

I thought I might as well update this here so that the ggeffects function can use model_info for everything including checking for multivariate models. Works for both is_multivariate and model_info.

Updated one test which which expected is_multivariate == FALSE, I imagine as a placeholder - it has two outcome variables.

I figure this is a cleaner solution but let me know if you'd rather leave as is.

strengejacke/ggeffects#432

@strengejacke
Copy link
Member

Thanks! Will look closer at your PRs later, but at first glance they look good!

@B0ydT
Copy link
Contributor Author

B0ydT commented Jan 28, 2024

Thanks! I've taken a look at some for the the failed checks, and they don't look related to my changes, but please let me know if I've missed something or can help in any way.

@strengejacke
Copy link
Member

Yes, should be good! Thanks!

@strengejacke strengejacke merged commit f0ef4c7 into easystats:main Jan 30, 2024
15 of 24 checks passed
@B0ydT B0ydT deleted the vgam_multivariate branch January 30, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants