Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-hex color scales #245

Merged
merged 8 commits into from
Oct 9, 2022
Merged

Add color-hex color scales #245

merged 8 commits into from
Oct 9, 2022

Conversation

bwiernik
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #245 (2321e4d) into main (ce242a8) will increase coverage by 0.00%.
The diff coverage is 43.24%.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   42.91%   42.91%           
=======================================
  Files          63       64    +1     
  Lines        4136     4173   +37     
=======================================
+ Hits         1775     1791   +16     
- Misses       2361     2382   +21     
Impacted Files Coverage Δ
R/scale_color_colorhex.R 43.24% <43.24%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwiernik
Copy link
Contributor Author

bwiernik commented Sep 29, 2022

@IndrajeetPatil could you help me write a test that won't make CRAN angry with failing URLs?

Use palette = 185 as the input and c("#3b5998", "#8b9dc3", "#dfe3ee", "#f7f7f7", "#ffffff") as the expected result

@IndrajeetPatil
Copy link
Member

The example still doesn't seem to work:

library(ggplot2)
library(see)

ggplot(iris, aes(x = Species, y = Sepal.Length, fill = Species)) +
  geom_violin() +
  theme_modern() +
  scale_fill_colorhex_d(palette = 1014416)
#> Error in self$palette(n): attempt to apply non-function

Created on 2022-09-30 with reprex v2.0.2

@IndrajeetPatil
Copy link
Member

@bwiernik Awaiting your response on this one.

@bwiernik
Copy link
Contributor Author

bwiernik commented Oct 4, 2022

ah, lovely bugs/poor programming in ggplot2::scale_color_gradientn()!

@IndrajeetPatil
Copy link
Member

Thanks for fixing! Will add the tests now.

@IndrajeetPatil IndrajeetPatil merged commit f5447a3 into main Oct 9, 2022
@IndrajeetPatil IndrajeetPatil deleted the josiah branch October 9, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants