Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p_function() plot #249 #250

Merged
merged 26 commits into from
Nov 5, 2022
Merged

p_function() plot #249 #250

merged 26 commits into from
Nov 5, 2022

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Nov 3, 2022

#249

  • get rid of one of the two legends when we have no facets
  • add back one legend title when we have no facets
  • remove legend for facets
  • how to have two color scales when we have no facets? I.e. one color-scale for the ribbons, and one for the vertical bars?
  • drop intercept by default
  • do we need to highlight the 95% CI at all?
  • include the null hypothesis (e.g., 0) and have a vertical bar there
  • italic lower case p

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #250 (b51146a) into main (31661ae) will decrease coverage by 0.96%.
The diff coverage is 0.99%.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   42.80%   41.83%   -0.97%     
==========================================
  Files          64       65       +1     
  Lines        4186     4283      +97     
==========================================
  Hits         1792     1792              
- Misses       2394     2491      +97     
Impacted Files Coverage Δ
R/plot.check_outliers.R 11.70% <0.00%> (ø)
R/plot.p_function.R 0.00% <0.00%> (ø)
R/geom_violindot.R 40.00% <33.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@strengejacke strengejacke mentioned this pull request Nov 3, 2022
@strengejacke

This comment was marked as outdated.

@strengejacke

This comment was marked as outdated.

@strengejacke
Copy link
Member Author

library(parameters)
library(see)

model <- lm(Sepal.Length ~ Species + Sepal.Width + Petal.Length, data = iris)
p <- p_function(model)

plot(p)

plot(p, show_labels = FALSE)

plot(p, n_columns = 1)

plot(p, n_columns = 2)

Created on 2022-11-05 with reprex v2.0.2

@strengejacke
Copy link
Member Author

@IndrajeetPatil any idea why checks are not working?

@IndrajeetPatil
Copy link
Member

@strengejacke Can you make sure that there is only one Remotes field in the DESCRIPTION file? Maybe that will fix the issue.

@strengejacke
Copy link
Member Author

strengejacke commented Nov 5, 2022

Ah, missed that one. Fixed now, moved it to the bottom, where those "additional" fields are easiest to find.

@strengejacke strengejacke merged commit 5e82fa9 into main Nov 5, 2022
@strengejacke strengejacke deleted the plot.p_value branch November 5, 2022 21:51
@bwiernik
Copy link
Contributor

bwiernik commented Nov 6, 2022

(I'll check the docs tomorrow)

@strengejacke
Copy link
Member Author

Yes, no hurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants