-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN RC: 0.8.3 #332
CRAN RC: 0.8.3 #332
Conversation
@strengejacke Can you go through the changes in snapshots and confirm that this is expected? I am surprised how much we have reduced the size of points; they are barely visible. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 43.89% 43.57% -0.33%
==========================================
Files 67 67
Lines 4882 4909 +27
==========================================
- Hits 2143 2139 -4
- Misses 2739 2770 +31 ☔ View full report in Codecov by Sentry. |
Maybe we can revert that? Points looked too big in check_model(), but rather small in single plots. |
Would you say it's ok now, or increase dot size even more? |
Yes, looks much better now! |
Closes #330