Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN RC: 0.8.3 #332

Merged
merged 17 commits into from
Mar 24, 2024
Merged

CRAN RC: 0.8.3 #332

merged 17 commits into from
Mar 24, 2024

Conversation

IndrajeetPatil
Copy link
Member

@IndrajeetPatil IndrajeetPatil commented Mar 23, 2024

Closes #330

@IndrajeetPatil
Copy link
Member Author

@strengejacke Can you go through the changes in snapshots and confirm that this is expected?

I am surprised how much we have reduced the size of points; they are barely visible.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.57%. Comparing base (bd5b6e1) to head (83e62c4).
Report is 2 commits behind head on main.

Files Patch % Lines
R/scale_color_social.R 0.00% 2 Missing ⚠️
R/scale_color_bluebrown.R 50.00% 1 Missing ⚠️
R/scale_color_metro.R 50.00% 1 Missing ⚠️
R/scale_color_pizza.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   43.89%   43.57%   -0.33%     
==========================================
  Files          67       67              
  Lines        4882     4909      +27     
==========================================
- Hits         2143     2139       -4     
- Misses       2739     2770      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke
Copy link
Member

@strengejacke Can you go through the changes in snapshots and confirm that this is expected?

I am surprised how much we have reduced the size of points; they are barely visible.

Maybe we can revert that? Points looked too big in check_model(), but rather small in single plots.

@strengejacke
Copy link
Member

Would you say it's ok now, or increase dot size even more?

@IndrajeetPatil
Copy link
Member Author

Would you say it's ok now, or increase dot size even more?

Yes, looks much better now!

R/scale_color_bluebrown.R Show resolved Hide resolved
DESCRIPTION Show resolved Hide resolved
@IndrajeetPatil IndrajeetPatil merged commit 1f50306 into main Mar 24, 2024
22 of 27 checks passed
@IndrajeetPatil IndrajeetPatil deleted the rc-cran-083 branch March 24, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN release?
2 participants