Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat retrieves full bridge state, excl. group 0 #3

Closed
ebaauw opened this issue Oct 23, 2016 · 1 comment
Closed

Heartbeat retrieves full bridge state, excl. group 0 #3

ebaauw opened this issue Oct 23, 2016 · 1 comment

Comments

@ebaauw
Copy link
Owner

ebaauw commented Oct 23, 2016

Currently, homebridge-hue retrieves the full bridge state, GET /, on each heartbeat. As this state doesn't include /groups/0, group 0 is currently not supported. Also, it might be more efficient to issue multiple requests, one for each resource type: GET /lights, GET /groups, GET /sensors, and GET /schedules, especially when you have a lot of rules. Of course, these requests would only be issued when the corresponding resource type is enabled through config.json.

@ebaauw ebaauw changed the title Heartbeat get state / group 0 Heartbeat retrieves full bridge state, excl. group 0 Oct 23, 2016
ebaauw pushed a commit that referenced this issue Oct 28, 2016
Changed HueBridge.prototype.request() from callback to Promise, to
support /groups/0 (issue #3) and to create bridge username (issue #10)
from homebridge-hue.
@ebaauw
Copy link
Owner Author

ebaauw commented Oct 28, 2016

homebridge-hue now does separate requests for /lights, /groups/0, /groups, /sensors, /schedules, and /rules, obviously depending in the configuration in config.json. This can be monitored by homebridge -D.

@ebaauw ebaauw closed this as completed Oct 28, 2016
ebaauw pushed a commit that referenced this issue Dec 10, 2016
- Quicker plug-in startup replaced timeout by Promise.all()
- Reverted issue #3, single GET / instead of GET /lights, GET /groups,
GET /sensors, …; but keep GET /groups/0
- Added config parameter to disable group 0
- Updated README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant