Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't hide the stdbool include from g-ir-scanner #131

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

lazka
Copy link
Contributor

@lazka lazka commented Dec 21, 2018

g-i recently lost the ability to infer the bool type without a stdbool include.
While this is about to be fixed in g-i (https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/116)
I don't see a reason why we should hide this in the first place, so remove the ifdef guard.

g-i recently lost the ability to infer the bool type without a stdbool include.
While this is about to be fixed in g-i (https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/116)
I don't see a reason why we should hide this in the first place, so remove the ifdef guard.
@ebassi
Copy link
Owner

ebassi commented Dec 21, 2018

The reason why I ignored it was because older g-ir-scanner versions would barf on bool.

I guess this means that graphene needs to depend on a minimum version of gobject-introspection.

@lazka
Copy link
Contributor Author

lazka commented Dec 21, 2018

OK, CI uses Debian stretch and I don't see any errors/warnings there. So >= 1.50 should work for example.

@ebassi
Copy link
Owner

ebassi commented Dec 21, 2018

Okay, let's merge this as is; I can add a requirement on 1.50 (and bump up the requirement for GLib 2.50) if that breaks elsewhere.

@ebassi ebassi merged commit 57be3ca into ebassi:master Dec 21, 2018
@lazka
Copy link
Contributor Author

lazka commented Dec 21, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants