Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphene_ray_transform #169

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Conversation

alexlarsson
Copy link
Contributor

We can't use graphene_matrix_transform_vec3() to transform the origin
because we need to point to respect transformations (but not the
directions, so we can use vec3 there instead of reconstructing
the direction).

Fixes #...

Proposed changes:

  • ...

Benchmark results:

  • Before: ...
  • After: ...

Test suite changes:

  • ...

We can't use graphene_matrix_transform_vec3() to transform the origin
because we need to point to respect transformations (but not the
directions, so we can use vec3 there instead of reconstructing
the direction).
@alexlarsson
Copy link
Contributor Author

I added support for raycasting to gthree HEAD (see examples/interactive), and without this its totally broken. With this fix it mostl works although sometimes it seems something goes wrong and nothing is selected.

Also, part of the support was adding a bunch of ray-to-$primitive helpers, and these should probably be in graphene: https://github.com/alexlarsson/gthree/blob/master/gthree/gthreemesh.c#L10

@ebassi ebassi merged commit c0fdadc into ebassi:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants