Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: pick up gobject from a subproject fallback as well #177

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

tp-m
Copy link
Contributor

@tp-m tp-m commented Jan 7, 2020

Makes graphene find gobject in a gst-build on Windows scenario.

@tp-m
Copy link
Contributor Author

tp-m commented Jan 7, 2020

There's something else I need to investigate as well g-ir-scanner related

@tp-m
Copy link
Contributor Author

tp-m commented Jan 7, 2020

There's something else I need to investigate as well g-ir-scanner related

Unrelated, this one should be good to go, I'll do a separate PR for other things.

Copy link
Contributor

@nirbheek nirbheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebassi
Copy link
Owner

ebassi commented Jan 8, 2020

I assume this works in the case where graphene is built as a sub-project of another Meson project that also depends on gobject?

It would be nice to leave a comment in the meson.build file to that effect.

Makes graphene find gobject in scenario where graphene is a
subproject of another GObject-using project and GObject comes
from a GLib subproject, as is commonly the case when building
GStreamer or GTK on Windows.
@tp-m tp-m force-pushed the meson-use-gobject-fallback-if-available branch from 0de8c9c to a51d8d1 Compare January 8, 2020 15:25
@tp-m
Copy link
Contributor Author

tp-m commented Jan 8, 2020

I assume this works in the case where graphene is built as a sub-project of another Meson project that also depends on gobject?

Correct. I'm trying to add graphene as subproject to GStreamers's gst-build (it's used in our OpenGL plugin in gst-plugins-base) and make things work on Windows where there's no system install of GObject.

It would be nice to leave a comment in the meson.build file to that effect.

Done. (Plus some gratuitious line wrapping, since it was getting a bit long.)

@ebassi ebassi merged commit 4b2409f into ebassi:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants