Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: expose graphene_gobject_dep variable for graphene-gobject #179

Merged

Conversation

tp-m
Copy link
Contributor

@tp-m tp-m commented Jan 8, 2020

Expose a separate variable for graphene-gobject for subproject usage
support, so the superproject and sibling subprojects can check for this
directly as part of the dependency() fallback: logic instead of having to
poke at the build_gobject subproject variable. This mirrors the pkg-config
lookup logic where we have a dedicated .pc file for graphene-gobject as well.
If gobject support was disabled the variable will be set to a not-found dep.

Expose a separate variable for graphene-gobject for subproject usage
support, so the superproject and sibling subprojects can check for this
directly as part of the dependency() fallback logic instead of having to
poke at the build_gobject subproject variable. This mirrors the pkg-config
lookup logic where we have a dedicated .pc file for graphene-gobject as well.
If gobject support was disabled the variable will be set to a not-found dep.
@tp-m tp-m force-pushed the meson-expose-dep-variable-for-graphene-gobject branch from 73aefec to 6edeb3a Compare January 8, 2020 00:42
Copy link
Contributor

@nirbheek nirbheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebassi ebassi merged commit 7c7ca67 into ebassi:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants