Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euler: Fix matrix orientation in euler matrix (de)composition #193

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

alexlarsson
Copy link
Contributor

The euler_to_matrix and matrix_to_euler code is based on:

https://github.com/matthew-brett/transforms3d/blob/master/transforms3d/euler.py

This is num-py and has the same row-major matrixes like graphene. However
that code is based on column vectors being multiplied with the matrix on
the left:

This module implements intrinsic and extrinsic axes, with standard conventions
for axes i, j, k. We assume that the matrix should be applied on the
left of the vector, and right-handed coordinate systems. To get the matrix to
apply on the right of the vector, you need the transpose of the matrix we
supply here, by the matrix transpose rule: $(M . V)^T = V^T M^T$.

To do the transpose we just change the matrix indexing macro (M) to swap
the row/column.

The euler_to_matrix and matrix_to_euler code is based on:

https://github.com/matthew-brett/transforms3d/blob/master/transforms3d/euler.py

This is num-py and has the same row-major matrixes like graphene. However
that code is based on column vectors being multiplied with the matrix on
the left:

> This module implements intrinsic and extrinsic axes, with standard conventions
> for axes `i`, `j`, `k`.  We assume that the matrix should be applied on the
> left of the vector, and right-handed coordinate systems.  To get the matrix to
> apply on the right of the vector, you need the transpose of the matrix we
> supply here, by the matrix transpose rule: $(M . V)^T = V^T M^T$.

To do the transpose we just change the matrix indexing macro (M) to swap
the row/column.
@ebassi ebassi merged commit 89a69ff into ebassi:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants