ray: Nudge ray direction of axis when intersecting #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formula used to calculate the inverse of the direction vector doesn't handle the direction vector aligning with an axis. Depending on the SIMD (or not SIMD) implementation used, a axis aligned vector would either remain the same, or e.g. end up with NaN components messing up any future calculations. Fixing the math to handle this is non-trivial, so for now work around this by nudging the direction vector slightly off axis so that it has a better hand of hitting the right box even when the direction is axis aligned. Closes: ebassi#214
rmader
reviewed
Mar 23, 2021
jadahl
force-pushed
the
wip/fix-ray-trace-on-axis
branch
from
1880955
to
9ca2fd0
Compare
ebassi
requested changes
Mar 23, 2021
ebassi
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formula used to calculate the inverse of the direction vector
doesn't handle the direction vector aligning with an axis. Depending on
the SIMD (or not SIMD) implementation used, a axis aligned vector would
either remain the same, or e.g. end up with NaN components messing up
any future calculations.
Fixing the math to handle this is non-trivial, so for now work around
this by nudging the direction vector slightly off axis so that it has a
better hand of hitting the right box even when the direction is axis
aligned.
Closes: #214
Fixes #...
Proposed changes:
Benchmark results:
Test suite changes: