Allow passing startDir to moduleconfig to avoid using cached module.parent #6
Conversation
| @@ -5,8 +5,13 @@ var cache = require("./cache"); //use requires caching to have a singleton | |||
| var getConfigPath = require("./getConfigPath"); //use requires caching to have a singleton | |||
| var path = require("path"); | |||
|
|
|||
| module.exports = function moduleConfig(paths, loadPathFunction) { | |||
| var startDir = path.dirname(module.parent.parent.filename); | |||
| module.exports = function moduleConfig(startDir, paths, loadPathFunction) { | |||
There was a problem hiding this comment.
make startDir optional and pass it as the last parameter - then it does not break existing usages
| module.exports = function moduleConfig(startDir, paths, loadPathFunction) { | |
| module.exports = function moduleConfig(paths, loadPathFunction, startDir) { |
There was a problem hiding this comment.
I agree this is a mess and I see that loadPathFunction is optional. Why not write your own module for moduleconfig?
There was a problem hiding this comment.
I think we just wanted to avoid releasing this package under our scope.
@hilleer Do you have any thoughts on this?
There was a problem hiding this comment.
Not really. whatever you find better/more suitable. Optimally I would simply pass an object to the function instead of optional arguments where the object has the optional options 🙂
|
I'm closing this PR as we decided to implement these changes in forked repository for now. |
This package doesn't work correctly together with Opentelemetry packages.
In short, opentelemetry uses
require-in-the-middlethat has its own cache in addition to require cache which makesmodule.parentin moduleConfig.js#L9 to always resolve to the same file.This issue has been described in open-telemetry/opentelemetry-js#3655. It has been fixed in
require-in-the-middlev7.0.0, but the additional cache has been reintroduced in v7.1.1.