-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added onInjectedCallback #16
Added onInjectedCallback #16
Conversation
…ered output for components.
Pull Request Test Coverage Report for Build 97
💛 - Coveralls |
Many thanks for the PR! Just a couple of observations: Could you please fix the above? Other than that it looks good. Thank you for adding |
… removed semicolons, renamed to , added a comment explaining the done callback for jest.
Ah, thanks for the feedback! I definitely approve of consistency, apologies for missing some of them -the latest should reflect all the suggestions. As for the onInjected test, that is actually testing to ensure it is being called. Based on the jest docs for async callbacks, the test will pass if done (and thus, onInjected) is called and fail otherwise. |
Hey @alfonsomunozpomer, just sending a quick ping in case you missed the pushed changes to the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, sorry it took a while to get this merged.
The primary new feature is adding a onInjectedCallback prop. The API matches the latest ReactSVG API for the onInjected prop :
2.1.0
since only a new prop was added.