Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“¦ atlas-information-banner πŸ’¬ Feature #177056273 – Add new info banner component #77

Merged

Conversation

upendrakumbham
Copy link
Contributor

A web banner component(atlas information component) to use in both web applications to encourage our users to participate in the survey.

Here is the pivotal story link

@alfonsomunozpomer alfonsomunozpomer changed the title Feature/177056273 add new info banner component πŸ“¦ atlas-information-banner πŸ’¬ Bugfix #177056273 – Add new info banner component Feb 26, 2021
@alfonsomunozpomer alfonsomunozpomer changed the title πŸ“¦ atlas-information-banner πŸ’¬ Bugfix #177056273 – Add new info banner component πŸ“¦ atlas-information-banner πŸ’¬ Feature #177056273 – Add new info banner component Feb 26, 2021
Comment on lines 9 to 14
test(`disappears when close button is clicked`, () => {
const wrapper = shallow(<AtlasInformationBanner/>)
expect(wrapper.state('visibility')).toHaveLength(0);
wrapper.find('a').last().simulate('click')
expect(wrapper.state('visibility')).toBe('none');
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€ πŸ₯‡

Copy link
Member

@alfonsomunozpomer alfonsomunozpomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-indent the code in AtlasInformationBanner.test.js to two spaces (our shared style in JavaScript code) and merge away.

@upendrakumbham upendrakumbham merged commit 20589cb into master Feb 26, 2021
@alfonsomunozpomer alfonsomunozpomer deleted the feature/177056273-add-new-info-banner-component branch March 2, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants