PyPy support #1
Merged
PyPy support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython is a fork that is better-maintained, and has better PyPy support. PyZephyr is simple enough that the switch appears to require no code changes.
|
CC: @timabbott |
|
"Explicitly hold references to PyObject_s after conversion to char_." references in the commit message an "object poo", which is presumably intended to be a "pool" Otherwise, lgtm. |
If we are holding onto the char* version of a PyObject*, we need to hold a reference to that PyObject itself. In CPython, the previous code generally works because the ZNotice object would hold a reference from __dict__. This assumption is not true in PyPy, and would also break in weirder cases like someone subclassing ZNotice and replacing 'cls' with a property. We can't just hold the objects in a Python list, because again, in PyPy, that results in conversion to PyPy's internal format, which does not hold onto the specific PyObject* generated by cpyext. So instead, write some C code to maintain an object pool of objects to which we need references.
|
Fixed! On Mon, Dec 31, 2012 at 3:42 PM, Tim Abbott notifications@github.comwrote:
|
|
Evan, do you want to review this, or should I go ahead and merge? |
|
I've skimmed it. Little bit sad that that's necessary, but seems fine. (Also fine with not having these go through me) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes python-zephyr work properly under PyPy, and fixes an admittedly-obscure bug under CPython. Not super-heavily tested, but san-checked.