BS2076-2 support #59
Merged
BS2076-2 support #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjnixon
force-pushed
the
bs2076-2
branch
2 times, most recently
from
b591609 to
c60634d
Compare
Co-authored by: Thomas Nixon <tom@tomn.co.uk>
last_pack_format and last_stream_format are now not set when making items, but this didn't make mush sense as these re part of the format
track validation is now run on unselected tracks too, because there's no reason to have an audioTrackUID without a track or channel reference
now, the building of ElementParser structures is mostly contained in the MainElementHandler class; things like different versions can be supported through different instances of this, and the behaviour for individual elements can be overridden by sub-classing this and passing instances to the parsing/formatting functions closes #38 this is option 2, which wasn't the plan, but that didn't consider needing different behaviours for different versions
the xml output is a bit of a testing blind-spot in general. this should be extended to cover more elements
this is useful when copying data between files, when there's no need to change the format
this will probably be annoying, because most v2 changes are uncontroversial, especially if new parameters are not used however, this is supposed to be a reference implementation of the standard, and we can't rule out possibility that the eventual standard will say to do something different for v2 files
90 degrees is not valid for M+110, but 100 is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #58