Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): allows more menu items - FRONT-3354 #2253

Merged
merged 9 commits into from
Dec 8, 2021
Merged

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Nov 9, 2021

Changed the way menu items are displayed in the mega menu; we no longer use fixed grid, but rely on the column-count property.

This PR also include accessibility improvement requested on https://citnet.tech.ec.europa.eu/CITnet/jira/browse/FRONT-3347

@emeryro emeryro self-assigned this Nov 9, 2021
@emeryro emeryro requested a review from a team November 9, 2021 07:06
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 keyboard tested and it works fine with focus.

@emeryro emeryro merged commit 7b984fd into v3-dev Dec 8, 2021
@emeryro emeryro deleted the FRONT-3354-menu branch December 8, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants